Show the Autofill completion case as what would be auto-filled #22819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Mar 17, 2025
presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionArgSuite.scala
Outdated
Show resolved
Hide resolved
natsukagami
force-pushed
the
pleasant-case-class-autofill
branch
from
4399efb to
a7e0ec0
Compare
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Apr 26, 2025
…#22819) Partial Fix for scalameta/metals#7274 We have in our completion provider an option to automatically fill a case class constructor with named parameters: ```scala case class A(x: Int, y: Int) val a = A(@@) ^^ // would fill in here val a = A(x = ???, y = ???) // ^^^ ^^^ cursor marks added, so tabs can be used to move between the fields ``` However previously it was labeled `Autofill with default values`, which would never pass editors' filters based on the current state of input (most likely the name of a field). The only way to find this option was to type something matching the `Autofill with default values` label, which explains the `auto` in the above issue. We now provide the actual provided fields as the label, so the above would show `x = ???, y = ???` instead, which is both more intuitive for the user, and more friendly to editors. [Cherry-picked 744ba92]
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Apr 27, 2025
…#22819) Partial Fix for scalameta/metals#7274 We have in our completion provider an option to automatically fill a case class constructor with named parameters: ```scala case class A(x: Int, y: Int) val a = A(@@) ^^ // would fill in here val a = A(x = ???, y = ???) // ^^^ ^^^ cursor marks added, so tabs can be used to move between the fields ``` However previously it was labeled `Autofill with default values`, which would never pass editors' filters based on the current state of input (most likely the name of a field). The only way to find this option was to type something matching the `Autofill with default values` label, which explains the `auto` in the above issue. We now provide the actual provided fields as the label, so the above would show `x = ???, y = ???` instead, which is both more intuitive for the user, and more friendly to editors. [Cherry-picked 744ba92]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Fix for scalameta/metals#7274
We have in our completion provider an option to automatically fill a case class constructor with named parameters:
However previously it was labeled
Autofill with default values, which would never pass editors' filters based on thecurrent state of input (most likely the name of a field).
The only way to find this option was to type something matching the
Autofill with default valueslabel, which explains theautoin the above issue.We now provide the actual provided fields as the label, so the above would show
x = ???, y = ???instead, which is bothmore intuitive for the user, and more friendly to editors.
As a fallback, the hidden text sent to editors for filtering still containsAutofill with default values, so typingautoor any old variant would still work as before.